Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade google-protobuf version to fix bundle size issues #1291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sayjeyhi
Copy link

@sayjeyhi sayjeyhi commented Oct 8, 2022

Based on this issue: protocolbuffers/protobuf-javascript#124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade google-protobuf version to fix bundle size issues.

Screen Shot 1401-07-16 at 12 07 54

Based on this issue: protocolbuffers/protobuf-javascript#124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade `google-protobuf` version to fix bundle size issues
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sayjeyhi / name: Jafar Rezaei (c092713)

@sayjeyhi
Copy link
Author

sayjeyhi commented Oct 8, 2022

This will close: #270

@sampajano
Copy link
Collaborator

sampajano commented Oct 11, 2022

@sayjeyhi Hi Jafar, thanks so much your contributions here! Really appreciate your initiative and efforts here! ❤️

Although.. when i just checked bundle size for google-protobuf again i've noticed it has reverted to original size (and actually a little bit higher than that)..

Screen Shot 2022-10-11 at 4 52 47 PM

I'm guessing it's due to this PR below:
protocolbuffers/protobuf-javascript#143

I wonder if you have any ideas on the above PR and whether it can be solved?

Thanks a lot!

@@ -30,7 +30,7 @@
"google-closure-compiler": "~20200224.0.0",
"google-closure-deps": "~20210601.0.0",
"google-closure-library": "~20210808.0.0",
"google-protobuf": "~3.14.0",
"google-protobuf": "~3.21.1",
Copy link
Collaborator

@sampajano sampajano Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, since this is only a "devDependencies" and is only used during development, it does not change the final output of the grpc-web npm package (which doesn't depend on google-protobuf directly).

What would make a difference is when developers start depending on [email protected] directly in their client applicaiton, like in our HelloWorld example:

"google-protobuf": "~3.14.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants