Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpml-acf-user-image-field.php: Improved compatibility with GF User Registration. #754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claygriffiths
Copy link
Contributor

@claygriffiths claygriffiths commented Jan 15, 2024

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2466624374/59384?folderId=1530128

Summary

When this snippet was used with GF User Registration to help GPFUP with rehydration, the file/image would be removed from the user if the existing file(s) were not modified.

@claygriffiths claygriffiths force-pushed the clay/gpml-acf-user-image-field-gfur branch from ce1b7a9 to f67f43a Compare January 15, 2024 04:40
@scyt scyt requested a review from spivurno February 15, 2024 16:57
@scyt
Copy link
Contributor

scyt commented Feb 15, 2024

Noticed this PR didn't have any reviewers assigned. Set this one to you @spivurno.

Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one requested change.

* If using this snippet with GF User Registration, we need to remove the mapping for the metakey to prevent GFUR
* from clearing out the value if an existing file is already set.
*/
function disable_gfur_for_metakey( $feeds, $entry, $form ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function disable_gfur_for_metakey( $feeds, $entry, $form ) {
function disable_gfur_for_meta_key( $feeds, $entry, $form ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants