Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move back to v16 #3773

Merged
merged 7 commits into from
Sep 10, 2024
Merged

move back to v16 #3773

merged 7 commits into from
Sep 10, 2024

Conversation

yaacovCR
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 4bb258d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
graphql-language-service-server Patch
@graphiql/plugin-code-exporter Patch
graphql-language-service-cli Patch
@graphiql/plugin-explorer Patch
graphql-language-service Patch
codemirror-graphql Patch
@graphiql/toolkit Patch
@graphiql/react Patch
monaco-graphql Patch
cm6-graphql Patch
graphiql Patch
vscode-graphql Patch
vscode-graphql-execution Patch
vscode-graphql-syntax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member

acao commented Sep 10, 2024

@yaacovCR just need a minor version changeset bump for graphiql and vscode-graphql

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (1118d42) to head (4bb258d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3773   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files         122      122           
  Lines        7003     7003           
  Branches     2240     2265   +25     
=======================================
  Hits         4575     4575           
  Misses       2411     2411           
  Partials       17       17           

see 1 file with indirect coverage changes

@acao
Copy link
Member

acao commented Sep 10, 2024

@yaacovCR there is a test that was added that counts number of modules from vite, and this changes when dependencies change, so you just need to change the number

CC @dimaMachina we need a better way to validate the tree shaking because this is confusing!

@acao
Copy link
Member

acao commented Sep 10, 2024

@yaacovCR thank you, this reverts the changes and cleans up some of our own mismatches!

@acao acao merged commit 31edfab into graphql:main Sep 10, 2024
14 checks passed
@yaacovCR yaacovCR deleted the move-back branch September 10, 2024 11:48
@acao acao mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants