Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Added some docs comments to better identify fields that are just named id #275

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented May 13, 2022

And to better spot where transaction hash can be found.

…d `id` and to better spot where transaction hash can be found
@maoueh maoueh marked this pull request as draft May 13, 2022 18:06
@maoueh
Copy link
Contributor Author

maoueh commented May 13, 2022

I need to re-write the comment removing mention of transactionHash as I mixed up Protobuf fields when I checked, so it's totally false, id are all receiptId.

@azf20
Copy link

azf20 commented May 15, 2022

@maoueh checking the status of this, my understanding was that it's not possible to get the tx hash for the receipt at this time, but your original comment suggested it was?

@maoueh
Copy link
Contributor Author

maoueh commented Jul 20, 2022

@azf20 That’s correct, I thought one of the id was the transaction hash/id, but I was wrong and all id fields are actually referring to the receipt id.

So, there is no way to obtain today the transaction hash (some changes in graph-node is required to support that, probably passing more context to the receipt handler).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants