feat: firehose live tracer #53
Conversation
eth/tracers/live/firehose.go
Outdated
| if f.isPrecompileAddress(a) { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
How this method is not working but propagating the precompile down to StateDB works. I think it will be important to understand what is the difference.
That being said, the native tracer Git commit s1na/go-ethereum@ee58cc7 implements it differently, I think porting those will be needed
There was a problem hiding this comment.
That being said, the native tracer Git commit s1na/go-ethereum@ee58cc7 implements it differently, I think porting those will be needed
These changes are already ported in statedb: precompile check before onNewAccount commit. I removed precompile check from here since it being done at statedb now.
How this method is not working but propagating the precompile down to StateDB works. I think it will be important to understand what is the difference.
In the old firehose implementation, we take the precompile flag on the AddBalance here. If you check the references of AddBalance, In majority of the cases we are sending hardcoded false instead of checking against the precompile config. Because of this even precompiled contracts are getting logged in the NewAccount in some cases.
Whereas in new implementation, each and every account was checked against the precompile config.
In this commit, I added a new flag checkPrecompile, that denotes if new account should be checked against precompiled address or not. I am sending checkPrecompile values according to the firehose old implementation to make the new tracer backward compatible.
@maoueh Let me know what you think
I have opened this PR just to monitor the change
Missing Commits
streamingfast/go-ethereum@8849451