Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Album configuration option to set the Album target in Google Photos #396

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

pacoorozco
Copy link
Member

@pacoorozco pacoorozco commented Oct 23, 2023

What issue type does this pull request address? (keep at least one, remove the others)
/kind feature

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #393

Add a new Album configuration option which can be used to set the album's name (name:albumName) or a replacement for the deprecated CreateAlbums option (auto:folderName or auto:folderPath).

It deprecates the CreateAlbums option, which will be maintained for backwards compatibility until next major version.

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, it offers a new way to set the target album in Google Photos.

It's still compatible with the previous CreateAlbums option.

Does this pull request add new dependencies?
No

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #396 (fee72d3) into main (fd7501c) will increase coverage by 0.80%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   64.51%   65.32%   +0.80%     
==========================================
  Files          22       22              
  Lines         916      946      +30     
==========================================
+ Hits          591      618      +27     
- Misses        302      304       +2     
- Partials       23       24       +1     
Files Coverage Δ
internal/upload/album.go 100.00% <100.00%> (ø)
internal/config/config.go 81.92% <88.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pacoorozco pacoorozco merged commit e97bfa0 into main Oct 23, 2023
5 checks passed
@pacoorozco pacoorozco deleted the issue-393 branch October 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a cli switch to specify the name of the album
1 participant