[#4384] CMake FetchContent_* does not work with GTest as dependency name on Windows #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global variable gtest_SOURCE_DIR is replaced by CMake when fetch-content is used with the name "GTest" and points to the root directory. The include directories from the gtest target are always valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt for gmock uses
gtest_SOURCE_DIRfor setting the include paths. When using fetch content with the name "GTest", the value ofgtest_SOURCE_DIRis updated to the repository root instead of the googletest subdirectory. As a result, gmock will fail to compile due to invalid include paths.This can be fixed by not relying on
gtest_SOURCE_DIRbut reading the include directories from the gtest target.It used to work for other compilers because gmock depends on gtest (using
target_link_libraries). So gmock had the broken include paths fromgtest_SOURCE_DIRplus the working paths from the target. For MSVC, gmock does not depend on gtest.fixed #4384