Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress clang-tidy warnings about goto statements #4327

Closed
wants to merge 1 commit into from
Closed

Suppress clang-tidy warnings about goto statements #4327

wants to merge 1 commit into from

Conversation

georgthegreat
Copy link
Contributor

@georgthegreat georgthegreat commented Aug 2, 2023 •
edited
Loading

Partially fixes #2442

@dinord
Copy link
Collaborator

dinord commented Aug 7, 2023

We typically don't accept NOLINTs in our headers. Although this is a macro, the goto is just an internal implementation detail.

I'd file a bug against Clang-Tidy to provide a way to disable it these types of warnings.

@dinord dinord closed this Aug 7, 2023
@georgthegreat
Copy link
Contributor Author

I'd file a bug against Clang-Tidy to provide a way to disable it these types of warnings.

But using NOLINTNEXTLINE is the way for clang-tidy to disable these types of warning.
You just have to add itto your code.

Once you will get rid of these goto statements, the NOLINT stanzas can be removed too.

@georgthegreat
Copy link
Contributor Author

And, btw,

We typically don't accept NOLINTs in our headers

This just is not true.
There are NOLINT marks all around the code.

@dinord, can we reopen and merge this?

robot-piglet pushed a commit to ytsaurus/ytsaurus that referenced this pull request Aug 11, 2023
@georgthegreat
Acklowledge patch unacceptance
56f6edb 
Upstreamed in google/googletest#4327, but was not accepted by the maintainers.
robot-piglet pushed a commit to ydb-platform/ydb that referenced this pull request Aug 11, 2023
@georgthegreat
Acklowledge patch unacceptance
0435311 
Upstreamed in google/googletest#4327, but was not accepted by the maintainers.
robot-piglet pushed a commit to ydb-platform/nbs that referenced this pull request Aug 11, 2023
@georgthegreat
Acklowledge patch unacceptance
abb2a32 
Upstreamed in google/googletest#4327, but was not accepted by the maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress Clang-Tidy warnings
2 participants
@georgthegreat @dinord