Support frame conds #3520
Closed
Support frame conds #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows a user to set a breakpoint condition targeting a specific frame. Fixes go-delve#3515
aarzilli
reviewed
Oct 9, 2023
| @@ -447,6 +449,10 @@ func evalBreakpointCondition(tgt *Target, thread Thread, cond ast.Expr) (bool, e | |||
| return true, err | |||
| } | |||
| } | |||
| scope, err = ConvertEvalScope(tgt, scope.g.ID, int(frameCond), 0) | |||
There was a problem hiding this comment.
This is going to break if the thread isn't running a goroutine. This could be the reason for all the new test failures.
That's interesting, I like that approach. That would mean landing this after your PR #3508. I can close this out for now and we can move forward with that approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows a user to set a breakpoint condition targeting a specific frame.
This is more of a partial implementation of the referenced issue because it does
not allow for setting multiple conditions. That, in my opinion, is a separate feature
request and can be implemented independently.
Fixes #3515