feat: add support for custom client properties #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same concern with this as #138, I wonder if it'd be better to allow for overwriting specific properties instead of the whole dict. |
|
Would you like another PR for this solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a quick PR which adds support for specifying the client_properties when creating the connection (in addition to providing the URL). This enables you to set certain properties (like connection_name) so that it will appear in the management interface on RabbitMQ.
Wasn't sure exactly how to test this, but I'll look at it some more if this seems like it is a good addition to the project.
Should be a non-breaking change with the default provided.