-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-56] Regular SubBlock Model #78
Conversation
Hey @CVasey, @dbrookes96, @rminhxm, @markgodresse, @jeremybutlermaptek, @bluetyson - Here is the first somewhat meaty PR up for review since getting you all on board to review. For a bit more context, you can take a look at the prototyping notebook linked in my previous comment. If you have comments on that, feel free to submit a review on the closed PR https://github.com/gmggroup/omf/pull/65 as well. Let me know if you have any questions! For more general discussion I also created https://github.com/gmggroup/omf/issues/79 |
Codecov Report
@@ Coverage Diff @@
## dev #78 +/- ##
==========================================
- Coverage 96.61% 95.05% -1.57%
==========================================
Files 11 10 -1
Lines 502 586 +84
==========================================
+ Hits 485 557 +72
- Misses 17 29 +12
Continue to review full report at Codecov.
|
VolumeGridElement
toTensorBlockModel