Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-56] Regular SubBlock Model #78

Merged
merged 12 commits into from
Jun 20, 2021
Merged

[GH-56] Regular SubBlock Model #78

merged 12 commits into from
Jun 20, 2021

Conversation

fwkoch
Copy link
Contributor

@fwkoch fwkoch commented May 24, 2019

@fwkoch
Copy link
Contributor Author

fwkoch commented May 24, 2019

Hey @CVasey, @dbrookes96, @rminhxm, @markgodresse, @jeremybutlermaptek, @bluetyson - Here is the first somewhat meaty PR up for review since getting you all on board to review. For a bit more context, you can take a look at the prototyping notebook linked in my previous comment. If you have comments on that, feel free to submit a review on the closed PR https://github.com/gmggroup/omf/pull/65 as well.

Let me know if you have any questions! For more general discussion I also created https://github.com/gmggroup/omf/issues/79

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #78 into dev will decrease coverage by 1.56%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #78      +/-   ##
==========================================
- Coverage   96.61%   95.05%   -1.57%     
==========================================
  Files          11       10       -1     
  Lines         502      586      +84     
==========================================
+ Hits          485      557      +72     
- Misses         17       29      +12
Impacted Files Coverage Δ
omf/__init__.py 100% <100%> (ø) ⬆️
omf/blockmodel.py 90.96% <88.79%> (-4.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dc6a9...7f3dce6. Read the comment docs.

@fwkoch fwkoch merged commit b665712 into dev Jun 20, 2021
@fwkoch fwkoch deleted the GH-56/regular_subblock branch June 20, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants