This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Add a .devcontainer #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ned Schwartz <[email protected]>
keithamus
approved these changes
Mar 1, 2022
|
hmmm I am noticing an issue when running tests in a Codespaces on this branch 03 03 2022 21:30:11.979:ERROR [launcher]: Cannot start ChromeHeadless
/workspaces/details-dialog-element/node_modules/chromium/lib/chromium/chrome-linux/chrome: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directoryIt appears that the new container we're specifying is missing some dependencies we need to run chromium. Maybe we need to add more Codespaces features? But what? |
theinterned
approved these changes
May 17, 2022
There was a problem hiding this comment.
This change is good! Though we should follow up with the same change in this PR github/auto-complete-element#88 to fix the issue with tests not running in codespaces.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kitchen sink image for Codespaces comes with node 14 and npm 6. We want to run node 16 and npm 8.
This PR creates a dockerfile and devcontainer to ensure that codespaces come with those newer versions.
Part of https://github.com/github/web-systems/issues/428