Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't invalidate grid rows more than once, fixes #1678 #1680

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

ghiscoding
Copy link
Owner

fixes #1678

  • see this comment for more details

Copy link

stackblitz bot commented Sep 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding mentioned this pull request Sep 14, 2024
5 tasks
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (ac7e6f9) to head (c01164c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1680     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       31087   31090      +3     
  Branches     9784    9785      +1     
========================================
+ Hits        30998   31001      +3     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 075d191 into master Sep 14, 2024
6 checks passed
@ghiscoding ghiscoding deleted the perf/grouping-rows-changed branch September 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping Performance Issue
1 participant