Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only import @excel-builder-vanilla/types for optional dep #1656

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 29, 2024

  • since Excel Export is an optional package, we shouldn't install the entire excel-builder-vanilla when the only thing we really use in the common package is the excel-builder-vanilla interfaces for the grid option interface, so we should really only import its types in the @slickgrid-universal/common package and no need to download/install the entire library since we only need its types.
  • So to deal with that, I created a new separate types only package. The new package @excel-builder-vanilla/types is only including the d.ts files so that we can use it in the grid options interface without installing the entire lib which is especially true for users who aren't install the Excel Export service @slickgrid-universal/excel-export

- since `excel-builder-vanilla` is an optional dependency, we should only import its types, I created a separate types only package to deal with that
Copy link

stackblitz bot commented Aug 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (ce8b400) to head (27e983e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1656   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         199     199           
  Lines       21889   21889           
  Branches     7327    7327           
======================================
  Hits        21827   21827           
  Misses         62      62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit b3a25fc into master Aug 29, 2024
12 checks passed
@ghiscoding ghiscoding deleted the bugfix/excel-builder-vanilla-types branch August 29, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant