fix: only import @excel-builder-vanilla/types
for optional dep
#1656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excel-builder-vanilla
when the only thing we really use in the common package is the excel-builder-vanilla interfaces for the grid option interface, so we should really only import its types in the@slickgrid-universal/common
package and no need to download/install the entire library since we only need its types.@excel-builder-vanilla/types
is only including thed.ts
files so that we can use it in the grid options interface without installing the entire lib which is especially true for users who aren't install the Excel Export service@slickgrid-universal/excel-export