chore: migrate from node-archiver to fflate to zip standalone SF bundle #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove old node-archiver implementation - NOTE: the new zip file is compatible with the previous implementation BUT it is a bit larger when using `fflate` (about 20Kb larger) - the larger file was explained in `fflate` GitHub Discussion: 101arrowz/fflate#195 - the main reason to use `fflate` instead of `node-archiver` is because our new `Excel-Builder-Vanilla` repo uses `fflate` and also because `fflate` is ESM and `node-archiver` is not and wasn't updated in a while, so even if the zip is slightly larger switching to fflate is still an improvement and doesn't really matter for Salesforce - new bundled zip file was also tested in Salesforce
- commitlint should accept multiple lines since I don't care about the PR body content but I do care about the PR title though
ghiscoding
changed the title
node-archiver to fflate to zip standalone vanilla bundle for SF
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1387 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 199 199
Lines 21557 21557
Branches 6937 6937
======================================
Hits 21493 21493
Misses 64 64 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 13, 2024
ghiscoding
added a commit
that referenced
this pull request
Feb 13, 2024
* chore(release): publish new version 4.4.0 * docs: add missing commit to changelog * chore: introduce husky commit-msg hook and pr title linter (#1385) * chore: setup husky commit-msg hook with commitlint * chore(deps): upgrade to major `@typescript-eslint` v7 (#1386) * chore(deps): upgrade to major `@typescript-eslint` v7 * chore: migrate from node-archiver to fflate to zip standalone SF bundle (#1387) * chore: replace bundle zip creation from `node-archiver` to `fflate` * chore(deps): update to latest pnpm action v3 - latest pnpm action is using Node 20 and drops Node 16 which is EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fflateinstead ofnode-archiveris because our newExcel-Builder-Vanilladependency usesfflateand also becausefflateis ESM andnode-archiveris not and it also didn't receive any update in a while, so even if the compress file is slightly larger switching tofflateis still an improvement and doesn't really matter for Salesforce usage.fflatefflateGitHub Discussion: How to use zlib to compress multiple files? 101arrowz/fflate#195