Add support for Sapling as a VCS as well. #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced support to ignore the `.sl` directory already, but that did not include support for the VCS interface. As a VCS, Sapling uses effectively the same interface as Mercurial, although notably it does not support Mercurial's `.hgignore` file, nor does it invent a new one: it uses `.gitignore`. I opted for copying the Mercurial implementation though, it looks more adequate.
carmenbianca
requested changes
Apr 27, 2024
There was a problem hiding this comment.
Hi @Flameeyes! Thanks for the pull request. This looks pretty good, but is missing some stuff. The #858 PR is a good example of things that need to be added:
- A change log entry
- A mention in README
- A small collection of tests
- A workflow where Sapling is installed and tested
Comment on lines
+293
to
+294
| if directory is None: | ||
| directory = Path.cwd() |
There was a problem hiding this comment.
This segment of code isn't needed. I'll remove it from the other methods too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Sapling as a VCS as well.
I introduced support to ignore the
.sldirectory already, but that didnot include support for the VCS interface.
As a VCS, Sapling uses effectively the same interface as Mercurial,
although notably it does not support Mercurial's
.hgignorefile, nordoes it invent a new one: it uses
.gitignore.I opted for copying the Mercurial implementation though, it looks
more adequate.