feat: add ConnectionType(ctx) for called methods to use #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=========================================
Coverage ? 71.72%
=========================================
Files ? 11
Lines ? 1510
Branches ? 0
=========================================
Hits ? 1083
Misses ? 329
Partials ? 98
|
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Jul 31, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Jul 31, 2024
|
filecoin-project/lotus#12327 here's the use-case for it |
masih
approved these changes
Jul 31, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 1, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 1, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 5, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 5, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 8, 2024
rvagg
added a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 9, 2024
rjan90
pushed a commit
to hanabi1224/lotus
that referenced
this pull request
Aug 12, 2024
rjan90
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
Aug 12, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case for this: lotus-gateway should be able to decide which methods are only available via websockets but we currently don't have a straightforward way to do this without snooping on the wire. This is a prerequisite for filecoin-project/lotus#11153 which I'm thinking is the right thing to do for stateful calls that we can't properly meter as per filecoin-project/lotus#11589.