Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.0 #571

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Release v0.1.0 #571

merged 1 commit into from
Aug 13, 2024

Conversation

Stebalien
Copy link
Member

No description provided.

Copy link

Fuzz test failed on commit a950d7d. To troubleshoot locally, download the seed corpus using GitHub CLI by running:

gh run download 10376604099 -n testdata

Alternatively, download directly from here.

Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if CI would make the tag on the right commit if this branch is not up to date with main; just something to watch out for.

@@ -1,3 +1,3 @@
{
"version": "v0.0.7"
"version": "v0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be grateful if you could write a commit message about why the minor upgrade, i.e. Manifest protocol version bump, breaking changes, etc. etc. 🙏

Mostly optimizations, but also includes some breaking changes.
Importantly:

1. Rebroadcast backoff is now configurable. This should be backwards
compatible with other nodes as long as the defaults are specified in the
manifest (other nodes will ignore those defaults). But it's definitely
an API breaking change.
2. If configured, we now attempt to align instances when catching up.
3. We've bumped the protocol version to 3 so we can detect nodes that
have these features.

Additionally:

1. We've added a ton of metrics, and improved many of the existing ones.
2. We've optimized message validation significantly.
Copy link

Suggested version: 0.1.0

Comparing to: v0.0.7 (diff)

Changes in configuration file(s):

diff --git a/go.mod b/go.mod
index 4fd939c..b9954a2 100644
--- a/go.mod
+++ b/go.mod
@@ -16,6 +16,7 @@ require (
 	github.com/libp2p/go-libp2p v0.35.0
 	github.com/libp2p/go-libp2p-pubsub v0.11.0
 	github.com/multiformats/go-multibase v0.2.0
+	github.com/parquet-go/parquet-go v0.23.0
 	github.com/stretchr/testify v1.9.0
 	github.com/urfave/cli/v2 v2.25.5
 	github.com/whyrusleeping/cbor-gen v0.1.1
@@ -29,6 +30,7 @@ require (
 )
 
 require (
+	github.com/andybalholm/brotli v1.1.0 // indirect
 	github.com/benbjohnson/clock v1.3.5 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
@@ -58,8 +60,8 @@ require (
 	github.com/jackpal/go-nat-pmp v1.0.2 // indirect
 	github.com/jbenet/go-temp-err-catcher v0.1.0 // indirect
 	github.com/jbenet/goprocess v0.1.4 // indirect
-	github.com/kilic/bls12-381 v0.1.0 // indirect
-	github.com/klauspost/compress v1.17.8 // indirect
+	github.com/kilic/bls12-381 v0.1.1-0.20220929213557-ca162e8a70f4 // indirect
+	github.com/klauspost/compress v1.17.9 // indirect
 	github.com/klauspost/cpuid/v2 v2.2.7 // indirect
 	github.com/koron/go-ssdp v0.0.4 // indirect
 	github.com/libp2p/go-buffer-pool v0.1.0 // indirect
@@ -73,6 +75,7 @@ require (
 	github.com/libp2p/zeroconf/v2 v2.2.0 // indirect
 	github.com/marten-seemann/tcp v0.0.0-20210406111302-dfbc87cc63fd // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
+	github.com/mattn/go-runewidth v0.0.15 // indirect
 	github.com/miekg/dns v1.1.58 // indirect
 	github.com/mikioh/tcpinfo v0.0.0-20190314235526-30a79bb1804b // indirect
 	github.com/mikioh/tcpopt v0.0.0-20190314235656-172688c1accc // indirect
@@ -88,9 +91,11 @@ require (
 	github.com/multiformats/go-multistream v0.5.0 // indirect
 	github.com/multiformats/go-varint v0.0.7 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
+	github.com/olekukonko/tablewriter v0.0.5 // indirect
 	github.com/onsi/ginkgo/v2 v2.15.0 // indirect
 	github.com/opencontainers/runtime-spec v1.2.0 // indirect
 	github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58 // indirect
+	github.com/pierrec/lz4/v4 v4.1.21 // indirect
 	github.com/pion/datachannel v1.5.6 // indirect
 	github.com/pion/dtls/v2 v2.2.11 // indirect
 	github.com/pion/ice/v2 v2.3.24 // indirect
@@ -117,7 +122,9 @@ require (
 	github.com/quic-go/quic-go v0.44.0 // indirect
 	github.com/quic-go/webtransport-go v0.8.0 // indirect
 	github.com/raulk/go-watchdog v1.3.0 // indirect
+	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
+	github.com/segmentio/encoding v0.4.0 // indirect
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/syndtr/goleveldb v1.0.0 // indirect

gorelease says:

# github.com/filecoin-project/go-f3/blssig
## incompatible changes
Verifier.Aggregate: removed
Verifier.Verify: removed
Verifier.VerifyAggregate: removed
Verifier: old is comparable, new is not
VerifierWithKeyOnG1: changed from func() Verifier to func() *Verifier

# github.com/filecoin-project/go-f3/certexchange/polling
## incompatible changes
PollResult.Progress: removed
## compatible changes
PollResult.NewCertificates: added
PollResult.ReceivedCertificates: added

# github.com/filecoin-project/go-f3/cmd/f3/msgdump
## compatible changes
package added

# github.com/filecoin-project/go-f3/ec
## incompatible changes
(*FakeEC).SetCurrentHead: removed
NewFakeEC: changed from func(context.Context, uint64, int64, time.Duration, github.com/filecoin-project/go-f3/gpbft.PowerEntries, bool) *FakeEC to func(context.Context, uint64, int64, time.Duration, github.com/filecoin-project/go-f3/gpbft.PowerEntries) *FakeEC
## compatible changes
(*FakeEC).Pause: added
(*FakeEC).Resume: added

# github.com/filecoin-project/go-f3/gpbft
## incompatible changes
ValidateMessage: removed
## compatible changes
WithMaxCachedInstances: added
WithMaxCachedMessagesPerInstance: added

# github.com/filecoin-project/go-f3/manifest
## incompatible changes
DefaultGpbftOptions: removed
VersionCapability: value changed from 2 to 3
## compatible changes
(*GpbftConfig).ToOptions: added
DefaultCatchUpAlignment: added
GpbftConfig.RebroadcastBackoffBase: added
GpbftConfig.RebroadcastBackoffExponent: added
GpbftConfig.RebroadcastBackoffMax: added
Manifest.CatchUpAlignment: added

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.1.0

gocompat says:

HEAD is now at d0091d7 Release 0.0.7 (#520)
Previous HEAD position was d0091d7 Release 0.0.7 (#520)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@Stebalien Stebalien added this pull request to the merge queue Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (52f49ca) to head (f40cb33).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   80.14%   79.91%   -0.23%     
==========================================
  Files          49       49              
  Lines        4492     4492              
==========================================
- Hits         3600     3590      -10     
- Misses        544      551       +7     
- Partials      348      351       +3     

see 5 files with indirect coverage changes

Merged via the queue into main with commit 4db84c3 Aug 13, 2024
16 checks passed
@Stebalien Stebalien deleted the steb/release branch August 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants