Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.glue.md GLUE Preprocess script is incorrect. #5449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adithya-gv
Copy link

What does this PR do?

The script for running fairseq-hydra-train is incorrect and uses the invalid flag -config-dir. Fixed it to the correct flag --config-dir.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yes.

@facebook-github-bot
Copy link
Contributor

Hi @adithya-gv!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@danlee2002
Copy link

i was wondering why my code wasn't working, thanks for pointing this out!!!!

@abishakex
Copy link

thanks for the clarification, hang tight!

@tejaswini-rb
Copy link

appreciate this clarification, thanks for sharing!

@oupadhyay
Copy link

Lifesaver!

@kanand39
Copy link

kanand39 commented Mar 5, 2024

This is amazing! I appreciate the carry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants