Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the screenshots in getting started page #4207

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

apicgg
Copy link
Contributor

@apicgg apicgg commented Sep 5, 2024

Update and add some new screenshots in getting started page for macos with android and ios. It makes easy for newer developers to follow the set up instructions with screenshots.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit f503abe
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66df193ac3f69a000821001c
😎 Deploy Preview https://deploy-preview-4207--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to mention that I'm not a huge fan of adding those screenshots as they get stale really quickly (basically whenever we bump compile SDK version on Android)

@apicgg
Copy link
Contributor Author

apicgg commented Sep 7, 2024

@cortinico Understood your POV. Thanks for the clarification.

@apicgg apicgg closed this Sep 7, 2024
@cortinico
Copy link
Contributor

@apicgg maybe we can merge the update to website/static/docs/assets/GettingStartedXcodeCommandLineTools.png as that screenshot is already there + is outdated

@apicgg apicgg reopened this Sep 9, 2024
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for diff to update only website/static/docs/assets/GettingStartedXcodeCommandLineTools.png before we can merge this 👍

@apicgg
Copy link
Contributor Author

apicgg commented Sep 9, 2024

Waiting for diff to update only website/static/docs/assets/GettingStartedXcodeCommandLineTools.png before we can merge this 👍

Done.

@apicgg
Copy link
Contributor Author

apicgg commented Sep 9, 2024

@cortinico Does it look good to merge as well? Let me know in case.

@cortinico cortinico merged commit 925de66 into facebook:main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants