bump metro minimum supported Node.js to 18.18 #1351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vzaidman
force-pushed
the
bump-metro-version-to-18.8
branch
2 times, most recently
from
e3f49c6
to
c9b2ea0
Compare
vzaidman
changed the title
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
bump-metro-version-to-18.8
branch
from
c9b2ea0
to
4b868be
Compare
vzaidman
changed the title
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vzaidman
force-pushed
the
bump-metro-version-to-18.8
branch
from
4b868be
to
14bcb2e
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: After bumping the minimum supported version of Node.js for react native in facebook/react-native-website#4211, this PR bumps the minimum supported version in Metro to 18.8. This will: * Align us with React-Native * Align us with the minimum version of our dev dependencies which comes from `typescript-eslint/typescript-eslint` (also 18.8 * This will allow us to install `yarn` packages on the minimum version of node without the `--ignore-engines` flag. * Allow us to get rid of the workaround for fetch in Node.js < 18.14 in `packages/metro/src/integration_tests/__tests__/server-test.js`. Changelog:**[Breaking]** Bump minimum supported Node.js version to 18.18 Pull Request resolved: #1351 Reviewed By: huntie Differential Revision: D62505043 Pulled By: vzaidman fbshipit-source-id: a9d013db36dc203a475770bb5a4dc6e96a64475b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bumping the minimum supported version of Node.js for react native in facebook/react-native-website#4211, this PR bumps the minimum supported version in Metro to 18.18.
This will:
@typescript-eslint/typescript-eslint(also 18.8yarnpackages on the minimum version of node without the--ignore-enginesflag.packages/metro/src/integration_tests/__tests__/server-test.js.Changelog: [Breaking] Bump minimum supported Node.js version to 18.18