Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy resources for python_boostrap rules. #676

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

valadez-abel
Copy link

This is an attempt to workaround symbolic link issues with windows remote execution for the python_boostrap_binary rules. With this change, #673, #674, and #675 no longer happen, and C++ compilation properly works.

There's previous art mentioning resources were copied before, in order to keep python happy:

# It seems that buck1 always copies, and that's important for Python rules
if ctx.attrs.copy:
output = ctx.actions.copied_dir(ctx.label.name, srcs)
else:
output = ctx.actions.symlinked_dir(ctx.label.name, srcs)

I'm happy to make any revisions and improve this change.

@facebook-github-bot
Copy link
Contributor

Hi @valadez-abel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@JakobDegen
Copy link
Contributor

I left some comments on the issues. While I don't fundamentally object to this, I'd like to understand what's different about your RE environment before proceeding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants