feat: seperate pointer from handle #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2023
…gth_safe to low level api
zshipko
approved these changes
Jan 3, 2024
Comment on lines
5
to
11
| const char *msg = "Hello, world!"; | ||
| ExtismPointer ptr = extism_alloc(extism_strlen(msg)); | ||
| assert(ptr > 0); | ||
| extism_store(ptr, (const uint8_t *)msg, extism_strlen(msg)); | ||
| assert(extism_length(ptr) == extism_strlen(msg)); | ||
| extism_output_set(ptr, extism_strlen(msg)); | ||
| ExtismHandle buf = extism_alloc(extism_strlen(msg)); | ||
| assert(buf > 0); | ||
| extism_store_to_handle(buf, 0, msg, extism_strlen(msg)); | ||
| assert(extism_length(buf) == extism_strlen(msg)); | ||
| extism_output_handle(buf); | ||
| return 0; |
There was a problem hiding this comment.
It's awesome that with the high-level API this just becomes:
extism_output_buf_from_sz("Hello, world");
return 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the c-pdk slightly safer by using separate types for
ExtismPointerand a pointer in extism memory to the start of data in a memory block (here calledExtismHandle.The functions taking
ExtismHandlecheck against the bounds of the memory block referenced. The functions takingExtismPointerare not available for use without#define EXTISM_ENABLE_LOW_LEVEL_APIAdditionally, the
szanddupfunctions now are available for all data that can be loaded in extism memory, not just input.Resolves #19