fix: warn when Hanami or Rails are not detected #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started noticing "Hanami not detected" lately. I'm not sure exactly what to recommend here, perhaps only output anything when `ENV["CI"] == "true"` or something like that.. but I think preferring warn -> stderr over puts -> stdout is a good start to lower the shoutiness of it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 20 20
Lines 612 612
Branches 133 133
=======================================
Hits 595 595
Misses 17 17 ☔ View full report in Codecov by Sentry. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started noticing "Hanami not detected" lately. I'm not sure exactly what to recommend here, perhaps only output anything when
ENV["CI"] == "true"or something like that.. but I think preferring warn -> stderr over puts -> stdout is a good start to lower the shoutiness of it.