Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort paths lexicographically so the order of paths is more stable and predictable #155

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

exoego
Copy link
Owner

@exoego exoego commented Dec 6, 2023

While working in #154, I noticed that the order or paths were changed unexpectedly.
More stable, predictable order will be preferrable.

@exoego exoego added enhancement New feature or request breaking-change labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ea88d2) 96.76% compared to head (d10c469) 96.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   96.76%   96.78%   +0.02%     
==========================================
  Files          14       14              
  Lines         433      436       +3     
  Branches       95       96       +1     
==========================================
+ Hits          419      422       +3     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego marked this pull request as ready for review December 6, 2023 10:45
@exoego exoego merged commit de5106c into master Dec 6, 2023
12 checks passed
@exoego exoego deleted the sort-paths branch December 6, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant