Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema cleaner parent['required'] may be nil #119

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rspec/openapi/schema_cleaner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
paths_to_objects.each do |path|
parent = base.dig(*path.take(path.length - 1))
# "required" array must not be present if empty
parent.delete('required') if parent['required'].empty?
parent.delete('required') if parent['required']&.empty?

Check warning on line 50 in lib/rspec/openapi/schema_cleaner.rb

View check run for this annotation

Codecov / codecov/patch

lib/rspec/openapi/schema_cleaner.rb#L50

Added line #L50 was not covered by tests

Check warning

Code scanning / Rubocop

Avoid `foo&.empty?` in conditionals. Warning

Lint/SafeNavigationWithEmpty: Avoid calling empty? with the safe navigation operator in conditionals.
end
end

Expand Down