requestBody should not merge requestBody from error examples (#154)

lib/rspec/openapi/schema_builder.rb

@@ -120,6 +120,7 @@ def build_parameter_name(key, value)
   def build_request_body(record)
     return nil if record.request_content_type.nil?
     return nil if record.request_params.empty?
+    return nil if record.status >= 400
 
     {
       content: {

spec/integration_tests/rails_test.rb

@@ -27,6 +27,7 @@
 }
 
 class TablesIndexTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   # Patch minitest's ordering of examples to match RSpec's
@@ -63,6 +64,7 @@ def test_does_not_return_tables_if_unauthorized
 end
 
 class TablesShowTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   # Patch minitest's ordering of examples to match RSpec's
@@ -88,6 +90,7 @@ def test_returns_a_table
 end
 
 class TablesCreateTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns a table' do
@@ -98,9 +101,27 @@ class TablesCreateTest < ActionDispatch::IntegrationTest
     }.to_json
     assert_response 201
   end
+
+  test 'fails to create a table' do
+    post '/tables', headers: { authorization: 'k0kubun', 'Content-Type': 'application/json' }, params: {
+      name: 'some_invalid_name',
+      description: 'description',
+      database_id: 2,
+    }.to_json
+    assert_response 422
+  end
+
+  test 'fails to create a table (2)' do
+    post '/tables', headers: { authorization: 'k0kubun', 'Content-Type': 'application/json' }, params: {
+      description: 'description',
+      database_id: 2,
+    }.to_json
+    assert_response 422
+  end
 end
 
 class TablesUpdateTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns a table' do
@@ -110,6 +131,7 @@ class TablesUpdateTest < ActionDispatch::IntegrationTest
 end
 
 class TablesDestroyTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns a table' do
@@ -124,6 +146,7 @@ class TablesDestroyTest < ActionDispatch::IntegrationTest
 end
 
 class ImageTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns a image payload' do
@@ -174,6 +197,7 @@ class ImageTest < ActionDispatch::IntegrationTest
 end
 
 class ExtraRoutesTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns the block content' do
@@ -183,6 +207,7 @@ class ExtraRoutesTest < ActionDispatch::IntegrationTest
 end
 
 class EngineTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns some content from the engine' do
@@ -192,6 +217,7 @@ class EngineTest < ActionDispatch::IntegrationTest
 end
 
 class EngineExtraRoutesTest < ActionDispatch::IntegrationTest
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   test 'returns the block content' do

spec/integration_tests/roda_test.rb

@@ -14,6 +14,7 @@
 class RodaTest < Minitest::Test
   include Rack::Test::Methods
 
+  i_suck_and_my_tests_are_order_dependent!
   openapi!
 
   def app

spec/rails/app/controllers/tables_controller.rb

@@ -17,7 +17,11 @@ def show
   end
 
   def create
-    render json: find_table, status: 201
+    if params[:name].blank? || params[:name] == 'some_invalid_name'
+      render json: { error: 'invalid name parameter' }, status: 422
+    else
+      render json: find_table, status: 201
+    end
   end
 
   def update

spec/rails/doc/openapi.json

@@ -630,6 +630,27 @@
                 }
               }
             }
+          },
+          "422": {
+            "description": "fails to create a table (2)",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "object",
+                  "properties": {
+                    "error": {
+                      "type": "string"
+                    }
+                  },
+                  "required": [
+                    "error"
+                  ]
+                },
+                "example": {
+                  "error": "invalid name parameter"
+                }
+              }
+            }
           }
         }
       }

spec/rails/doc/openapi.yaml

@@ -409,6 +409,19 @@ paths:
                 storage_size: 12.3
                 created_at: '2020-07-17T00:00:00+00:00'
                 updated_at: '2020-07-17T00:00:00+00:00'
+        '422':
+          description: fails to create a table (2)
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  error:
+                    type: string
+                required:
+                - error
+              example:
+                error: invalid name parameter
   "/tables/{id}":
     get:
       summary: show

spec/requests/rails_spec.rb

@@ -87,6 +87,23 @@
       }.to_json
       expect(response.status).to eq(201)
     end
+
+    it 'fails to create a table' do
+      post '/tables', headers: { authorization: 'k0kubun', 'Content-Type': 'application/json' }, params: {
+        description: 'description',
+        database_id: 2,
+      }.to_json
+      expect(response.status).to eq(422)
+    end
+
+    it 'fails to create a table (2)' do
+      post '/tables', headers: { authorization: 'k0kubun', 'Content-Type': 'application/json' }, params: {
+        name: 'some_invalid_name',
+        description: 'description',
+        database_id: 2,
+      }.to_json
+      expect(response.status).to eq(422)
+    end
   end
 
   describe '#update' do