Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Remarks not in include_size_comparison is when size changed #88

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

exoego
Copy link
Owner

@exoego exoego commented Sep 3, 2024

Part of #87

Rows are shown regardless of sizeComparisonFilters when each bundle's size get changed

@exoego exoego added the bug Something isn't working label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

📦 esbuild Bundle Analysis for esbuild-bundle-analyzer

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
tmp/meta.json dist/index.mjs 131.18 KB ✅ -364 B (-0.3%)
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: tmp/meta.json, Out file: dist/index.mjs

Path Size
node_modules/minimatch/dist ${{\color{Goldenrod}{ █████ }}}$ 20.4%, 18.21 KB
node_modules/path-scurry/dist ${{\color{Goldenrod}{ ████▊ }}}$ 19.3%, 17.23 KB
node_modules/lru-cache/dist ${{\color{Goldenrod}{ ████▋ }}}$ 18.6%, 16.61 KB
node_modules/glob/dist ${{\color{Goldenrod}{ ████▌ }}}$ 18.2%, 16.23 KB
node_modules/minipass/dist ${{\color{Goldenrod}{ ██▋ }}}$ 10.9%, 9.79 KB
src/compare.ts ${{\color{Goldenrod}{ █▋ }}}$ 6.7%, 6.02 KB
node_modules/brace-expansion/index.js ${{\color{Goldenrod}{ ▌ }}}$ 2.4%, 2.11 KB
src/index.ts ${{\color{Goldenrod}{ ▎ }}}$ 1.4%, 1.26 KB
src/report.ts ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 994 B
node_modules/balanced-match/index.js ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 618 B
src/utils.ts ${{\color{Goldenrod}{ }}}$ 0.4%, 354 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@exoego exoego merged commit 865b43c into main Sep 3, 2024
4 checks passed
@exoego exoego deleted the fix-87 branch September 3, 2024 03:09
@exoego exoego changed the title bugfix: size comparison not needed here bugfix: Remarks not in include_size_comparison is when size changed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant