Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: show_no_change should not default to true #84

Merged
merged 2 commits into from
Aug 20, 2024
+4 −5
Merged

bugfix: show_no_change should not default to true #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab6088
bugfix: invert logic
exoego Aug 20, 2024
5949a31
bugfix: remove default value
exoego Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ inputs:
If `true`, a collapsed "details" section is rendered. It explains the details of the numbers provided and icons.
show_no_change:
required: false
default: "true"
deprecationMessage: |
Use the `include_size_comparison` list to show/hide `no-change`.
description: |
Expand Down
4 changes: 2 additions & 2 deletions dist/index.mjs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ function getInput(): Input {
const rawShowNoChange = getSingleInput("show_no_change");
if (rawShowNoChange !== "") {
if (getBooleanInput("show_no_change", "true")) {
filters.delete("no-change");
filters.add("no-change");
console.log(
"`show_no_change: true` is deprecated. Instead, remove `no-change` from the `include_size_comparison` list.",
);
} else {
filters.add("no-change");
filters.delete("no-change");
console.log(
"`show_no_change: false` is deprecated. Instead, add `no-change` to the `include_size_comparison` list.",
);
Expand Down