Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hidden comment at start instead of end to avoid truncation #72

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

palexcast
Copy link

@palexcast palexcast commented Aug 2, 2024

Adds hidden comment at the start instead of the end to avoid being removed if the comment is too long.

Too long comments are automatically truncated, and the hidden comment is then removed.

See earlier discussion here: #66

Copy link

github-actions bot commented Aug 2, 2024

📦 esbuild Bundle Analysis for esbuild-bundle-analyzer

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
tmp/meta.json dist/index.mjs 125.57 KB ⚠️ +3.38 KB (+2.8%)
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: tmp/meta.json, Out file: dist/index.mjs

Path Size
node_modules/minimatch/dist ${{\color{Goldenrod}{ █████▏ }}}$ 20.6%, 18.21 KB
node_modules/path-scurry/dist ${{\color{Goldenrod}{ ████▉ }}}$ 19.5%, 17.23 KB
node_modules/lru-cache/dist ${{\color{Goldenrod}{ ████▋ }}}$ 18.8%, 16.61 KB
node_modules/glob/dist ${{\color{Goldenrod}{ ████▌ }}}$ 18.4%, 16.23 KB
node_modules/minipass/dist ${{\color{Goldenrod}{ ██▊ }}}$ 11.1%, 9.79 KB
src/compare.ts ${{\color{Goldenrod}{ █▌ }}}$ 6.4%, 5.64 KB
node_modules/brace-expansion/index.js ${{\color{Goldenrod}{ ▌ }}}$ 2.4%, 2.11 KB
src/report.ts ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 994 B
src/index.ts ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 727 B
node_modules/balanced-match/index.js ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 618 B
src/utils.ts ${{\color{Goldenrod}{ }}}$ 0.3%, 224 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@palexcast palexcast changed the title Fix/add hidden comment at start fix: add hidden comment at start instead of end to avoid truncation Aug 2, 2024
Copy link
Owner

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now it makes sense to me.
Thanks for fixing it!

@exoego exoego added the bug Something isn't working label Aug 2, 2024
@exoego exoego merged commit c6c6c11 into exoego:main Aug 2, 2024
4 checks passed
@exoego exoego mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants