Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step example to README #28

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

yonta
Copy link
Contributor

@yonta yonta commented May 24, 2024

close #26

exoego
exoego previously approved these changes May 24, 2024
Copy link
Owner

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.
Thanks 👍

@exoego
Copy link
Owner

exoego commented May 24, 2024

CI fails at peter-evans/create-or-update-comment@v4 step 🤔
It appears related to GITHUB_TOKEN permission for external contributors?
https://github.com/exoego/esbuild-bundle-analyzer/actions/runs/9219330816/job/25364750063?pr=28
image

@exoego exoego closed this May 24, 2024
@exoego exoego reopened this May 24, 2024
Comment on lines 7 to 9
pull_request:
branches: [main]
pull_request_target:
Copy link
Owner

@exoego exoego May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
branches: [main]
pull_request_target:
pull_request:
branches: [main]
pull_request_target:

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@exoego exoego merged commit ff45152 into exoego:main May 24, 2024
2 checks passed
@exoego exoego added the documentation Improvements or additions to documentation label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build step example to README
2 participants