Merge pull request #84 from exoego/bugfix

bugfix: show_no_change should not default to true
exoego · Aug 20, 2024 · 5c6947f · 5c6947f
2 parents fd4243d + 5949a31
commit 5c6947f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/action.yaml b/action.yaml
@@ -63,7 +63,6 @@ inputs:
       If `true`, a collapsed "details" section is rendered. It explains the details of the numbers provided and icons.
   show_no_change:
     required: false
-    default: "true"
     deprecationMessage: |
       Use the `include_size_comparison` list to show/hide `no-change`.
     description: |

diff --git a/dist/index.mjs b/dist/index.mjs
diff --git a/src/index.ts b/src/index.ts
@@ -37,12 +37,12 @@ function getInput(): Input {
 	const rawShowNoChange = getSingleInput("show_no_change");
 	if (rawShowNoChange !== "") {
 		if (getBooleanInput("show_no_change", "true")) {
-			filters.delete("no-change");
+			filters.add("no-change");
 			console.log(
 				"`show_no_change: true` is deprecated. Instead, remove `no-change` from the `include_size_comparison` list.",
 			);
 		} else {
-			filters.add("no-change");
+			filters.delete("no-change");
 			console.log(
 				"`show_no_change: false` is deprecated. Instead, add `no-change` to the `include_size_comparison` list.",
 			);