Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for Gotta Snatch'Em All #686

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

nico-or
Copy link
Contributor

@nico-or nico-or commented Apr 26, 2024

Add a test case for totalCards using a singleton list as input since there it wasn't any before.

Discussed in issue #684

Add a test case for totalCards using a singleton list as input since there it wasn't any before.

Discussed in issue exercism#684
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@nico-or
Copy link
Contributor Author

nico-or commented Apr 26, 2024

I wasn't aware of the [no important files changed] flag. Should I add it to the commit body to avoid the re-run of tests?

@nico-or nico-or marked this pull request as draft April 26, 2024 18:51
@jiegillet
Copy link
Contributor

I wasn't aware of the [no important files changed] flag. Should I add it to the commit body to avoid the re-run of tests?

No don't, this new test could potentially reveal issues with some solutions, rerunning the tests is what we want :)

@jiegillet
Copy link
Contributor

@nico-or any reason why this is still a draft?

@nico-or nico-or marked this pull request as ready for review May 3, 2024 01:54
@nico-or
Copy link
Contributor Author

nico-or commented May 3, 2024

@nico-or any reason why this is still a draft?

No, I just forgot to switch the status.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@jiegillet jiegillet merged commit ea5cccf into exercism:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants