-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI to new script #510
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After much time and thought, I'm closing this because the snapshot system brings more complexity than gain. I've come to trust the current CI but having gone through this I now know how to make it better, for example, I finally figured out everything needed to do it the way I originally intended it to but never quite got working right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves verification of exercises by testing each exercise in their unsolved as well as their solved states.
Additionally, a pesky bug was finally fixed which resulted in the workaround in #475, which means CI is once again a true integration test.
Credit goes to @miridius, who wrote an amazing testing script as a way to verify recent improvements made to the test-runner: exercism/clojure-test-runner#42 (comment)
All that was needed was to figure out exactly how to adapt it to work in our CI environment. This was done during a live Exercism Dev Stream: https://www.youtube.com/watch?v=r2ejFqKlIlY