Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: cobra.ExactValidArgs method is deprecated #18612

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kamandlou
Copy link

cobra.ExactValidArgs method is deprecated I update cobra.ExactValidArgs method to cobra.MatchAll method

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kamandlou
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @Kamandlou. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Kamandlou
Copy link
Author

and alose use errors.Is for error equality checks

@ivanvc
Copy link
Member

ivanvc commented Sep 20, 2024

/ok-to-test

Hi @Kamandlou, thanks for your pull request. Regarding the changes to use errors.Is(), they may overlap with #18615 (part of #18576). To avoid conflicts, could you please limit your PR to include only the change to cobra.MatchAll()?

Thanks again, Amir!

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (2ed418c) to head (ecd3976).
Report is 8 commits behind head on main.

Current head ecd3976 differs from pull request most recent head 968f13a

Please upload reports for the commit 968f13a to get more accurate results.

Files with missing lines Patch % Lines
server/etcdserver/api/v3discovery/discovery.go 0.00% 1 Missing and 1 partial ⚠️
server/etcdserver/server.go 66.66% 2 Missing ⚠️
etcdctl/ctlv3/command/completion_command.go 0.00% 1 Missing ⚠️
pkg/proxy/server.go 50.00% 1 Missing ⚠️
server/etcdserver/v3_server.go 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/v3compactor/periodic.go 90.24% <100.00%> (ø)
etcdctl/ctlv3/command/completion_command.go 0.00% <0.00%> (ø)
pkg/proxy/server.go 60.95% <50.00%> (+0.33%) ⬆️
server/etcdserver/v3_server.go 72.57% <87.50%> (-1.32%) ⬇️
server/etcdserver/api/v3discovery/discovery.go 67.80% <0.00%> (ø)
server/etcdserver/server.go 81.34% <66.66%> (+0.44%) ⬆️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18612      +/-   ##
==========================================
- Coverage   68.83%   68.76%   -0.07%     
==========================================
  Files         420      420              
  Lines       35474    35519      +45     
==========================================
+ Hits        24418    24425       +7     
- Misses       9636     9668      +32     
- Partials     1420     1426       +6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed418c...968f13a. Read the comment docs.

@Kamandlou
Copy link
Author

Kamandlou commented Sep 21, 2024

/ok-to-test

Hi @Kamandlou, thanks for your pull request. Regarding the changes to use errors.Is(), they may overlap with #18615 (part of #18576). To avoid conflicts, could you please limit your PR to include only the change to cobra.MatchAll()?

Thanks again, Amir!

Hi @ivanvc, Done :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants