-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: cobra.ExactValidArgs
method is deprecated
#18612
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kamandlou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Kamandlou. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
and alose use |
/ok-to-test Hi @Kamandlou, thanks for your pull request. Regarding the changes to use Thanks again, Amir! |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18612 +/- ##
==========================================
- Coverage 68.83% 68.76% -0.07%
==========================================
Files 420 420
Lines 35474 35519 +45
==========================================
+ Hits 24418 24425 +7
- Misses 9636 9668 +32
- Partials 1420 1426 +6 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Kamandlou <[email protected]>
Signed-off-by: Kamandlou <[email protected]>
Signed-off-by: Kamandlou <[email protected]>
This reverts commit 72c2ccd. Signed-off-by: Kamandlou <[email protected]>
This reverts commit bf02247. Signed-off-by: Kamandlou <[email protected]>
Signed-off-by: Kamandlou <[email protected]>
Hi @ivanvc, Done :)) |
cobra.ExactValidArgs
method is deprecated I updatecobra.ExactValidArgs
method tocobra.MatchAll
method