[WIP]backport pkg/expect enhancements from main #18051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ArkaSaha30. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ArkaSaha30
changed the title
ArkaSaha30
force-pushed
the
backport-pkg-expect-enhancements
branch
3 times, most recently
from
70726c4
to
d9615e2
Compare
…ead of SIGKILL Signed-off-by: Eval EXEC <[email protected]> Signed-off-by: ArkaSaha30 <[email protected]>
ArkaSaha30
force-pushed
the
backport-pkg-expect-enhancements
branch
from
d9615e2
to
4f33d5b
Compare
Fixes issue 14275, flakes close to timeout like TestKVDelete. Signed-off-by: Thomas Jungblut <[email protected]> Signed-off-by: ArkaSaha30 <[email protected]>
This should aid in debugging test flakes, especially in tests where the process is restarted very often and thus changes its pid. Now it's a lot easier to grep for different members, also when different tests fail at the same time. The test TestDowngradeUpgradeClusterOf3 as mentioned in etcd-io#13167 is a good example for that. Signed-off-by: Thomas Jungblut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will backport pkg/expect enhancements from main to LTS branch release-3.5 to keep the test framework consistent.
Issue: #17869
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.