Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #589

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Dec 27, 2023

refs: eslint/eslint#17595

blocked by #590

@aladdin-add
Copy link
Member Author

converting to draft - not sure why the test failed.

@aladdin-add aladdin-add force-pushed the feat/node.js-18 branch 3 times, most recently from e39b3dd to b07ae92 Compare December 29, 2023 03:20
@nzakas
Copy link
Member

nzakas commented Jan 2, 2024

Maybe a result of the Acorn bugs?

@nzakas
Copy link
Member

nzakas commented Jan 11, 2024

Where are we on this?

@aladdin-add
Copy link
Member Author

blocked by #590, and it's blocked by acorn.

@nzakas
Copy link
Member

nzakas commented Jan 16, 2024

Is there an Acorn issue we can track?

@aladdin-add
Copy link
Member Author

seems no, will file one later.

@aladdin-add aladdin-add marked this pull request as ready for review January 25, 2024 02:31
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit e79cfa4 into main Jan 25, 2024
10 checks passed
@mdjermanovic mdjermanovic deleted the feat/node.js-18 branch January 25, 2024 09:57
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants