Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test is_https_redirect via public api #3064

Merged
merged 4 commits into from
Feb 23, 2024
Merged

test is_https_redirect via public api #3064

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
596ed19
test `is_https_redirect` via public api
T-256 Jan 16, 2024
75114a1
Merge branch 'master' into is_https_redirect
T-256 Feb 23, 2024
cec9e02
Merge branch 'master' into is_https_redirect
T-256 Feb 23, 2024
ec7a632
Update tests/test_utils.py
T-256 Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
URLPattern,
get_ca_bundle_from_env,
get_environment_proxies,
is_https_redirect,
same_origin,
)

Expand Down Expand Up @@ -237,21 +236,39 @@ def test_not_same_origin():


def test_is_https_redirect():
url = httpx.URL("http://example.com")
location = httpx.URL("https://example.com")
assert is_https_redirect(url, location)
url = httpx.URL("https://example.com")
request = httpx.Request(
"GET", "http://example.com", headers={"Authorization": "empty"}
)

client = httpx.Client()
headers = client._redirect_headers(request, url, "GET")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. Is there a way around that allows us to test this against public API?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be that we're okay with leaning on implementation details a little bit, certainly not a terrible trade-off to make. (I think we already have some instances of this in our test cases right?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we already use private-accessors in another test:

httpx/tests/client/test_proxies.py

Lines 333 to 338 in 4f6edf3

def test_proxy_with_mounts():
proxy_transport = httpx.HTTPTransport(proxy="http://127.0.0.1")
client = httpx.Client(mounts={"http://": proxy_transport})
transport = client._transport_for_url(httpx.URL("http://example.com"))
assert transport == proxy_transport


assert "Authorization" in headers


def test_is_not_https_redirect():
url = httpx.URL("http://example.com")
location = httpx.URL("https://www.example.com")
assert not is_https_redirect(url, location)
url = httpx.URL("https://www.example.com")
request = httpx.Request(
"GET", "http://example.com", headers={"Authorization": "empty"}
)

client = httpx.Client()
headers = client._redirect_headers(request, url, "GET")

assert "Authorization" not in headers


def test_is_not_https_redirect_if_not_default_ports():
url = httpx.URL("http://example.com:9999")
location = httpx.URL("https://example.com:1337")
assert not is_https_redirect(url, location)
url = httpx.URL("https://example.com:1337")
request = httpx.Request(
"GET", "http://example.com:9999", headers={"Authorization": "empty"}
)

client = httpx.Client()
headers = client._redirect_headers(request, url, "GET")

assert "Authorization" not in headers


@pytest.mark.parametrize(
Expand Down