fix(h2_connection_reset): add stream reset when client cancel the req… #944
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkLux
force-pushed
the
fix/h2_connection_reset
branch
from
7455935
to
9924db4
Compare
tomchristie
reviewed
Aug 30, 2024
tomchristie
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Thanks, seems like a good start. Make sure to run scripts/unasync.py to also apply the changes to the httpcore/_sync/http2.py module.
https://github.com/encode/httpcore/actions/runs/10464774808/job/28978912844#step:5:26
(Related... maybe we could change the build logs when unasync --check fails, so that there's clearer feedback to the developer.)
MarkLux
force-pushed
the
fix/h2_connection_reset
branch
4 times, most recently
from
46031e9
to
5997901
Compare
MarkLux
commented
Sep 4, 2024
MarkLux
force-pushed
the
fix/h2_connection_reset
branch
3 times, most recently
from
af2e7e4
to
c061e4f
Compare
MarkLux
force-pushed
the
fix/h2_connection_reset
branch
from
bd4f039
to
18422ff
Compare
|
sorry to bother but we are really in a hurry to fix this one, could you have a review again? @tomchristie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add the missing connection reset of h2 connection when client cancel the request.
fix #943
in discussion with #941