Handle directories in url_stat() #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two bugs here to fix.
parse_url()cannot handlefoo://style strings. It just returns false. So in that case we need to manually parse the string. (This is arguably a core bug, but there's already an Internals thread about how to replaceparse_url()with something that sucks less.)Filesystem::fileSize()chokes on a directory, which makesurl_stat()fail on directories.This patch fixes both, and causes my test cases to work in my app. However! The new test I added here still fails with a visibility error. I cannot get my CLI debugger connected properly on this app and cannot run Pest tests directly from IntelliJ (just PHPUnit), so I cannot reasonably debug further myself.