Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warn option of event_api.tags.illegal #16461

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Sep 17, 2024

_Do Not Merge until we got approval from breaking changes committee _

Release notes

Removed the --event_api.tags.illegal warn option, which allowed setting non string values to the tags field. Since v9, such assignments will fail, resulting in a _tagsparsefailure in the tags field, and the illegal value will be written to the _tags field.

What does this PR do?

The commit removes the --event_api.tags.illegal warn option which is added in #14822

Why is it important/What is the impact to the user?

This is a breaking change. User no longer be able to set event_api.tags.illegal to warn as a fallback to accept the illegal assignment of tags field.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • run with --event_api.tags.illegal warn throws Invalid option
  • --event_api.tags.illegal rename work as expected

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@kaisecheng kaisecheng marked this pull request as ready for review September 17, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove event_api.tags.illegal (default becomes locked to 'rename')
3 participants