Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event_api.tags.illegal (default becomes locked to 'rename') #16356

Open
robbavey opened this issue Jul 25, 2024 · 0 comments · May be fixed by #16461
Open

Remove event_api.tags.illegal (default becomes locked to 'rename') #16356

robbavey opened this issue Jul 25, 2024 · 0 comments · May be fixed by #16461

Comments

@robbavey
Copy link
Member

robbavey commented Jul 25, 2024

In #14822, we introduced the ability to guard against the use of the "reserved" field name tags. As part of that change, we introduced a setting event_api.tags.illegal that could be set with warn, which would still allow the previous behaviour, and continue to set the field tag, and only warn against it's use, and rename, which would move the illegal value and put it into a new _tags field.

We should remove this setting, and always use the behaviour currently provided by the rename setting

  • Mark setting as obsolete in 9.0
  • Update 8.x deprecation log to state that this setting is being removed in 9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment