Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'fleet-server-insecure-http' setting from docs #1274

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

kilfoyle
Copy link
Contributor

Apparently the setting fleet-server-insecure-http was removed by elastic/kibana#129371
This updates the docs to remove mention of the removed setting.

Closes: #1273

@kilfoyle kilfoyle requested a review from nchaulet August 30, 2024 13:06
@kilfoyle kilfoyle requested a review from a team as a code owner August 30, 2024 13:06
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 4, 2024

@nchaulet When you have a minute can you review this one, please?

@nchaulet
Copy link
Member

nchaulet commented Sep 4, 2024

@kilfoyle I am not sure about that one, the UI do not allow to setup an http fleet server, but the option --fleet-server-insecure-http still exists in fleet server and it possible to create an http fleet server hosts with the Fleet API, this is only used for testing/development.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 4, 2024

Thanks @nchaulet! I'll update the parent issue accordingly.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 4, 2024

Actually, if the setting is used only for testing & development, perhaps we should just remove it from the docs anyway. What do you think?

@nchaulet
Copy link
Member

nchaulet commented Sep 4, 2024

Actually, if the setting is used only for testing & development, perhaps we should just remove it from the docs anyway. What do you think?

Yes it's probably better as there is no reason for an end user to use those settings

@kilfoyle kilfoyle merged commit 735f788 into elastic:main Sep 4, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 735f788)
kilfoyle added a commit that referenced this pull request Sep 4, 2024
(cherry picked from commit 735f788)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation contains a description of the non-existent environment variable FLEET_SERVER_INSECURE_HTTP
3 participants