Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for agent unenrollment timeout setting #1259

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

kilfoyle
Copy link
Contributor

This updates the Elastic Agent policies page with the new unenrollment timeout setting added via elastic/kibana#189861

Target: 8.16
Closes: #1225

Welcome back @criamico! Please let me know if I've missed anything.

Preview

Screenshot 2024-08-15 at 3 15 53 PM

@kilfoyle kilfoyle requested a review from criamico August 15, 2024 19:20
@kilfoyle kilfoyle requested a review from a team as a code owner August 15, 2024 19:20
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

criamico
criamico previously approved these changes Aug 20, 2024
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karenzone
karenzone previously approved these changes Aug 20, 2024
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions inline for considerations. Otherwise, LGTM. 🚀

docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/agent-policies.asciidoc Outdated Show resolved Hide resolved
@kilfoyle kilfoyle dismissed stale reviews from karenzone and criamico via c6fc453 August 20, 2024 13:46
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kilfoyle kilfoyle merged commit 6e4afa0 into elastic:main Aug 20, 2024
3 checks passed
@kilfoyle
Copy link
Contributor Author

I forgot to mention... Thanks @criamico for re-approving! The kilfoyle dismissed stale reviews from karenzone and criamico is some frustrating automation that was added to this repo for security purposes. I would never dismiss anyone's review. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: Document new task that automatically unenrolls inactive agents
3 participants