-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for 'unprivileged' agent docs #1200
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might need another 👀 from the developers, but in the meanwhile, 🙇♂️ Thanks
docs/en/ingest-management/elastic-agent/elastic-agent-unprivileged-mode.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-unprivileged-mode.asciidoc
Show resolved
Hide resolved
Yes, I would agree that
I can understand the confusion 🙂. We sometimes refer to the the word that comes after the initial |
Thanks @lucabelluccini and @ycombinator for clearing things up! I've added in commands for |
docs/en/ingest-management/elastic-agent/elastic-agent-unprivileged-mode.asciidoc
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/elastic-agent-unprivileged-mode.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixes for 'unprivileged' agent docs * Add clause about required re-enroll * fixup * Improve warning about running sub-commands without sudo * Add 'privileged' and 'unprivileged' as commands * Note that sudo is still needed for install command * fixup * Fixup (cherry picked from commit e409b9d)
* Fixes for 'unprivileged' agent docs * Add clause about required re-enroll * fixup * Improve warning about running sub-commands without sudo * Add 'privileged' and 'unprivileged' as commands * Note that sudo is still needed for install command * fixup * Fixup (cherry picked from commit e409b9d) Co-authored-by: David Kilfoyle <[email protected]>
This updates the Run Elastic Agent without administrative privileges page based on suggestions in #1197
Closes: #1197
Preview pages:
Fixes mapped to the "Unprivileged mode docs review" issue
Updates the warning about running commands in unprivileged mode to be more clear.
Describes the
privileged
andunprivileged
commands for changing an agent's running mode.Nothing to do for now.
Adds steps to view an agent's running status (privileged vs unprivileged) in the "Agent details" UI.
Nothing to do for now.
Additional fix
--privileged
parameter to theelastic-agent install
command.@ycombinator Do you think
elastic-agent privileged
andelastic-agent unprivileged
should also be documented as full commands, similar toelastic-agent inspect
,elastic-agent status
, etc.? From Addunprivileged
andprivileged
subcommand to Elastic Agent elastic-agent#4621 it seems so. That is, they're actual commands rather than just parameters on theelastic-agent install
command. However, these are also referred to as "subcommands" so I'm kind of puzzled. :-)