-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about '/liveness' endpoint for standalone agent #1090
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved w/ suggest!
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
ADD: The "Enable agent monitoring" setting in Fleet wasn't documented at all, so I've added it to the Elastic Agent policies page that applies to Fleet-managed agents. @cmacknz @nimarezainia If the |
…agent-monitoring.asciidoc Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -38,6 +38,11 @@ To enable monitoring, set `agent.monitoring.enabled` to `true`. Also set the | |||
collected. If neither setting is specified, monitoring is turned off. Set | |||
`use_output` to specify the output to which monitoring events are sent. | |||
|
|||
Setting `agent.monitoring.enabled` to `true` also exposes a `/liveness` endpoint. By default, the endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually agent.monitoring.enabled.http
that needs to be enabled, agent.monitoring.enabled
controls whether we collect monitoring data from agent to be shipped to Fleet.
The liveness probe is an HTTP feature. Sorry for the late review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this @cmacknz!
A couple of questions:
- Just to make sure I get it right, should it be
agent.monitoring.enabled.http
oragent.monitoring.http.enabled
? In your comment you mentioned the latter. - I don't think the setting is available to in Fleet, so I think I should mention the setting only in the standalone agent docs (here). Does that seem right to you?
ADD: Here's a PR with the changes: #1100
The current documentation still does not reflect the new @kilfoyle can you please fix that? |
Thanks @nimarezainia! |
So this will work only for standalone Agents? |
How? |
I see elastic/kibana#180922 (comment) , so this is not yet fully functional in fleet |
It isn't in the Fleet UI yet, but the Fleet overrides API will let you control it. We have tests proving Fleet can control the parameters, there just isn't a UI box for it yet. The request to turn on the HTTP endpoint, which also enables the /liveness endpoint would look something like the following from dev tools:
There is a |
Fleet UI changes: elastic/kibana#153950 |
This updates the "Configure monitoring for standalone Elastic Agents" docs page to include mention of the
/liveness
endpoint added for 8.15. Rel: elastic/elastic-agent#107 (comment)ADD: Please see my comment below for an additional change to the Fleet-managed agent docs.
Closes: #1090