fix: update cmdutil.Reader to use os.Openfile #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fin09pcap
force-pushed
the
bug/readerRetry
branch
from
cb1c413
to
6c193b2
Compare
fix: update logic to include os.Stat fix: remove use of filepath.Clean fix: update name to not colide with package, i.e bytes fix: update logic to not change directories but use the file path name Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Requires introspection into failure for pkg pkg/container/seal/v2 Signed-off-by: Ben Stickel <[email protected]>
fin09pcap
force-pushed
the
bug/readerRetry
branch
from
d832f4e
to
0c78f04
Compare
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
fin09pcap
force-pushed
the
bug/readerRetry
branch
from
9d4024c
to
fdf1e98
Compare
fin09pcap
changed the title
jordansirwin
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
cmdutil.Readerto useos.Openfile.Add additional details for error formatting to assist debugging.