-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RuleSet] add support for annotations and labels #271
Merged
fin09pcap
merged 10 commits into
elastic:main
from
fin09pcap:ruleset/add_support_for_annotations_and_labels
Jun 27, 2023
Merged
[RuleSet] add support for annotations and labels #271
fin09pcap
merged 10 commits into
elastic:main
from
fin09pcap:ruleset/add_support_for_annotations_and_labels
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanvice
previously requested changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to allow it to pass lint
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
Signed-off-by: Ben Stickel <[email protected]>
fin09pcap
force-pushed
the
ruleset/add_support_for_annotations_and_labels
branch
from
June 27, 2023 23:21
8524d46
to
5f6d466
Compare
renanvice
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for generation of additional metadata when using the bundle as the source for a ruleSet.
When validating bundles, this update include all annotations and labels in the RuleSet.
The expected output should include all defined annotations and labels for the secret.
Validate against the generated bundle.