Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mapTo feature, see #1398 #1399

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Added mapTo feature, see #1398 #1399

merged 2 commits into from
Mar 26, 2024

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Mar 25, 2024

As titled, see #1398

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Based on my limited knowledge of PHP and without having tested it.

if ($class !== stdClass::class && !property_exists($obj, $field)) {
continue;
}
switch($response['columns'][$i]['type']) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a file in Elasticsearch where we can see all the classes? It would be nice to add it in a comment if we have it, in case more types are added in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezimuel
Copy link
Contributor Author

ezimuel commented Mar 26, 2024

Thanks @pquentin for the review.

@ezimuel ezimuel merged commit acade92 into main Mar 26, 2024
11 of 12 checks passed
@ezimuel ezimuel deleted the feature/mapto branch March 26, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants