Fix Response\Elasticsearch::offsetGet() return type declaration
#1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaNtagiou
force-pushed
the
annantagiou/fix-offset-get-return-type-declaration
branch
from
146e37c
to
3fc4907
Compare
AnnaNtagiou
force-pushed
the
annantagiou/fix-offset-get-return-type-declaration
branch
from
3fc4907
to
262086b
Compare
|
@ezimuel can you approve the workflow please? |
AnnaNtagiou
changed the title
Response\Elasticsearch::offsetGet() return type declaration
|
@ezimuel, thanks for approving the workflow! The CI is green. The failure is not related to my changes. |
|
@ezimuel What's needed to get this merged and tagged? It would be great to silence the error reported by Symfony. |
|
@ezimuel, you are probably very busy, but could you please let me know what needs to be done to move this PR forward? Thanks |
|
@AnnaNtagiou sorry for the delay, just merged. Thanks! |
|
Thanks for merging it, will a tag follow soon as well? 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384